Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43969 )
Change subject: smbios: Fix type 17 for Windows 10
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43969/5/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/43969/5/src/arch/x86/smbios.c@1079
PS5, Line 1079: max_capacity_mib * MiB
This apparently overflows
Yes, among other problems, this was indeed overflowing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43969
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc3a363cbc3d0654dafd4176c4f4af9005210f42
Gerrit-Change-Number: 43969
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Wed, 29 Jul 2020 14:08:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment