HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42448 )
Change subject: temporarily silent GCC on none reliable macro ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42448/3/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42448/3/Makefile.inc@416 PS3, Line 416: not reliable
I'd say `previously unaffected` instead
Done
https://review.coreboot.org/c/coreboot/+/42448/3/Makefile.inc@416 PS3, Line 416: waring
warning
Done
https://review.coreboot.org/c/coreboot/+/42448/2/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/42448/2/src/northbridge/intel/ironl... PS2, Line 1778: :0;
That is completely wrong.
Done
https://review.coreboot.org/c/coreboot/+/42448/3/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/42448/3/src/northbridge/intel/ironl... PS3, Line 1805: // if (reply.command != (MKHI_SET_UMA | (1 << 7)))
No, initialize `reply` instead. This is wrong.
Done