Attention is currently required from: Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Nick Vaccaro, Paul Menzel, Pratikkumar V Prajapati, Sowmya Aralguppe, Tarun.
Subrata Banik has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83106?usp=email )
Change subject: soc/intel: Adapt crashlog IP to also support 64-bit
......................................................................
Patch Set 22:
(2 comments)
Patchset:
PS22:
I think it's fine but I don't know crashlog well enough to be sure.
Thanks Angel
PS22:
@sowmya.aralguppe@intel.com: can you please check below prints w/ and w/o your CL?
w/o this CL
```
[DEBUG] m_cpu_crashLog_size : 0x4000 bytes
[DEBUG] CPU crashLog present.
[DEBUG] CPU crash data size: 0x4000 bytes in 0x5 region(s).
[DEBUG] CPU crashlog storage_off asserted
[DEBUG] CPU crashlog re_arm asserted
[DEBUG] crashlog size:pmc-0x1050, cpu-0x4000
[DEBUG] crashlog size:pmc-0x1050, cpu-0x4000
[DEBUG] crashlog size:pmc-0x1050, cpu-0x4000
```
w/ this CL
```
[DEBUG] m_cpu_crashLog_size : 0x824C bytes
[DEBUG] CPU crashLog present.
[DEBUG] CPU crash data size: 0x824C bytes in 0x5 region(s).
[DEBUG] CPU crashlog storage_off asserted
[DEBUG] CPU crashlog re_arm asserted
[DEBUG] crashlog size:pmc-0x1050, cpu-0x824c
[DEBUG] crashlog size:pmc-0x1050, cpu-0x824c
[DEBUG] crashlog size:pmc-0x1050, cpu-0x824c
```
I felt the CPU crashlog size is always higher with your CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83106?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I552257d3770abb409e2dcd8a13392506b5e7feb7
Gerrit-Change-Number: 83106
Gerrit-PatchSet: 22
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 26 Jun 2024 08:32:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com