Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46402 )
Change subject: soc/mediatek/mt8192: devapc: add basic devapc drivers
......................................................................
Patch Set 46:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46402/46//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46402/46//COMMIT_MSG@9
PS46, Line 9: s
nit: missing period
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/Ma...
File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/Ma...
PS46, Line 44: ramstage-y += devapc.c
Put it before dpm.c
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/de...
File src/soc/mediatek/mt8192/devapc.c:
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/de...
PS46, Line 16:
Remove extra indents
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46402
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ad47c86b88047c76854a6f8a67b251b6a9d4013
Gerrit-Change-Number: 46402
Gerrit-PatchSet: 46
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Assignee: Nina-CM Wu
nina-cm.wu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nina-CM Wu
nina-cm.wu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Dec 2020 03:34:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment