[coreboot-gerrit] Change in coreboot[master]: mb/*/*{i440BX}: Enable console in bootblock

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36775 )

Change subject: mb/*/*{i440BX}: Enable console in bootblock
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36775/5/src/mainboard/asus/p2b-ls/e... 
File src/mainboard/asus/p2b-ls/early_init.c:

https://review.coreboot.org/c/coreboot/+/36775/5/src/mainboard/asus/p2b-ls/e... 
PS5, Line 46: #endif
> > Why guard it at all?
>
> early_smbus.c needs to be linked in the bootblock

I don't think so, garbage collection should take care of it
before it tries to link it.
> and smbus_read_byte needs to be guarded in the header to not conflict in ramstage.

Only if `device/smbus.h` is included as well. I don't see any
conditional includes, I'm confused.