Attention is currently required from: Varshit B Pandya, Subrata Banik, Maulik V Vaghela, Rizwan Qureshi, Sugnan Prabhu S, Tim Wawrzynczak. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61020 )
Change subject: src/driver/wifi: Add _DSM method for DDRRFIM ......................................................................
Patch Set 11:
(2 comments)
Patchset:
PS11: I think we should take a slightly different approach here.
The problem we need to solve is the drivers/wifi/generic driver needs to know whether or not DDR RFIM is enabled for the CNVi device. Right now that is enabled via an SoC config, which means that, as is, this code would have to reach into the SoC chip, which is not really what we want here.
Instead, I think we can reverse where the CnviDdrRfim option lives; we can move it here, in this chip driver, and then the SoC code can go ask this code whether or not it's enabled, since the SoC is the one that knows whether or not it will have a CNVi device.
Here is a WIP patch about what I am thinking: https://review.coreboot.org/c/coreboot/+/61638 this should make it easier to implement this and also will work for future platforms
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/61020/comment/22a5c36b_5d866f42 PS11, Line 152: static void wifi_dsm_ddrrfim_func3_cb(void *ptr)
I believe this code need little more generalisation (refer to src/drivers//uart/acpi/acpi. […]
I have an idea of how this property can be better organized, I pushed a WIP patch here: https://review.coreboot.org/c/coreboot/+/61638