Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32375 )
Change subject: postcar_loader: Use size_t ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32375/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/32375/13//COMMIT_MSG@9 PS13, Line 9: To make it easier to pop arguments from stack use size_t instead of int.
There's a lot of assumptions in this sentence and no comments in the code. […]
Yes. postcar is being ran from x86-64 mode as well as the stage that is pushing values. This is due to rmodules nature, which can be only loaded from a stage that has the same arch. If that's no longer true the postcar frame will be broken.
Right now all values are poped from stack, such that the consumer will always do "size_t" reads. We could pack msrs into one value, but I don't see the benefit.