[coreboot-gerrit] [M] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Put options in CFR cbtable

[Benjamin Doron (Code Review)]

Attention is currently required from: Sean Rhodes, Christian Walter, Angel Pons, Maximilian Brune, Lean Sheng Tan.

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 )

Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> One patch, one file and one Kconfig option. […]

We discussed this in the parent change. Despite using `lb_new_record()`, CFR is one memory structure. This happens by building CFR all at once. Separating the generation risks fragmenting the structure into individual forms with the same tag.

To my understanding, that's out-of-spec, but potentially tolerated by CBTABLE. However, consumers don't expect it - for instance, EDK2 `FindCbTag()` only returns the first instance.

One way to do it at present is stashing references to forms in a list, but since this is the status quo for CMOS too, I don't think it's worth it.