build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30985 )
Change subject: postcarpayload: Boot to payload from postcar stage directly [WIP] ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/30985/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/30985/1/src/cpu/x86/mp_init.c@202 PS1, Line 202: for (i=0; i < CONFIG_MAX_CPUS; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/30985/1/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/#/c/30985/1/src/include/memlayout.h@43 PS1, Line 43: #define ARCH_STAGE_HAS_HEAP_SECTION (ENV_RAMSTAGE || ENV_SMM || ENV_RMODULE || ENV_POSTCAR) line over 80 characters
https://review.coreboot.org/#/c/30985/1/src/soc/intel/icelake/payload_init.c File src/soc/intel/icelake/payload_init.c:
https://review.coreboot.org/#/c/30985/1/src/soc/intel/icelake/payload_init.c... PS1, Line 178: #endif trailing whitespace
https://review.coreboot.org/#/c/30985/1/src/soc/intel/icelake/payload_init.c... PS1, Line 184: outb(0xcb, 0xb2); trailing whitespace
https://review.coreboot.org/#/c/30985/1/src/soc/intel/icelake/payload_init.c... PS1, Line 191: trailing whitespace