[coreboot-gerrit] Change in ...coreboot[master]: autoport: Add support for Haswell-LynxPoint platform

[Iru Cai (vimacs) (Code Review)]

Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )

Change subject: autoport: Add support for Haswell-LynxPoint platform
......................................................................


Patch Set 4:

(5 comments)

https://review.coreboot.org/#/c/30890/1/util/autoport/haswell.go 
File util/autoport/haswell.go:

https://review.coreboot.org/#/c/30890/1/util/autoport/haswell.go@92 
PS1, Line 92:
> Non-ULT boards will need to select `TSC_MONOTONIC_TIMER` to boot. They […]
> Done

https://review.coreboot.org/#/c/30890/1/util/autoport/lynxpoint.go 
File util/autoport/lynxpoint.go:

https://review.coreboot.org/#/c/30890/1/util/autoport/lynxpoint.go@311 
PS1, Line 311: FIXME: check this
> Yup, I was caught unawares by this.
> Done

https://review.coreboot.org/#/c/30890/1/util/autoport/lynxpoint.go@320 
PS1, Line 320: 	pdo1 := PCIMap[PCIAddr{Bus: 0, Dev: 0x1d, Func: 0}].ConfigDump[0x64]
             : 	ocmap1 := PCIMap[PCIAddr{Bus: 0, Dev: 0x1d, Func: 0}].ConfigDump[0x74:0x78]
             : 	pdo2 := PCIMap[PCIAddr{Bus: 0, Dev: 0x1a, Func: 0}].ConfigDump[0x64]
             : 	ocmap2 := PCIMap[PCIAddr{Bus: 0, Dev: 0x1a, Func: 0}].ConfigDump[0x74:0x78]
> It's possible for the USB 2 ports to be routed to the xHCI controller, […]
> Done

https://review.coreboot.org/#/c/30890/1/util/autoport/lynxpoint.go@461 
PS1, Line 461: 	RegisterPCI(0x8086, 0x1c22, GenericPCI{MissingParent: "smbus"})
             : 	RegisterPCI(0x8086, 0x1e22, GenericPCI{MissingParent: "smbus"})
> Oh, I just copied these IDs from lynxpoint/smbus.c, and didn't check the document.
> Done

https://review.coreboot.org/#/c/30890/1/util/autoport/lynxpoint.go@494 
PS1, Line 494: 	RegisterPCI(0x8086, 0x8c33, GenericPCI{})
> Some boards may have the thermal device 1f.6 (0x8c24) enabled. […]
> Done