Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35271 )
Change subject: soc/amd/common/lpc: Add SuperIO decode function ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35271/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/35271/1/src/soc/amd/common/block/in... PS1, Line 78: #define DECODE_SIO_4E4F 1
Reading the code is obvious, but not here. […]
I'm OK with redefining the 4e4f and 2e2f values.
I don't see the point in doing both, and given the work for eSPI, I want to start being more judicious about simply turning on as much decoding as possible. Is there a real-world scenario for that? And if so, the caller could simply make two calls, or the common code could be updated then.
Similarly, do we need a mask? It seems like the most common scenario is enabling bits, not disabling. I have a disable function that clears all LPC decoding, but that's really because the PSP is leaving stuff turned on (at least with the APCB we're currently using).