Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39857 )
Change subject: mb/google/volteer: Create Malefor variant
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee...
PS6, Line 83: DN_20K
The full table copy from Ripto, and Ripto used DN_20K. […]
I don't think we should have those PD even in ripto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbeebb13e537287686344740211143df35b7863a
Gerrit-Change-Number: 39857
Gerrit-PatchSet: 6
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-CC: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Comment-Date: Thu, 02 Apr 2020 05:01:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: William Wei
wenxu.wei@bitland.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment