Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45334 )
Change subject: mb/google/zork: Set USB3 port to force gen1 for morphius and ezkinil ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45334/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45334/15//COMMIT_MSG@9 PS15, Line 9: all Wrap please? 72 characters max for commit messages.
https://review.coreboot.org/c/coreboot/+/45334/15/src/mainboard/google/zork/... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45334/15/src/mainboard/google/zork/... PS15, Line 29: .ports.xhci0_port3 = 1, What if a PCO part is used? Do we care about XHCI1?
https://review.coreboot.org/c/coreboot/+/45334/15/src/mainboard/google/zork/... File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45334/15/src/mainboard/google/zork/... PS15, Line 26: .ports.xhci0_port1 = 1, Nit: Maybe add some comments? // USB-A Left, USB-A Right or something?