Attention is currently required from: Maulik V Vaghela, Jeremy Soller, Michał Kopeć, Tim Wawrzynczak, Paul Menzel, Ronak Kanabar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64074 )
Change subject: soc/intel/alderlake/hsphy: Add support for HSPHY firmware loading ......................................................................
Patch Set 3: Verified-1
(11 comments)
File src/soc/intel/alderlake/hsphy.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/454402c9_f129a98e PS3, Line 28: #define HSPHY_PAYLOAD_SIZE 32*KiB Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/356a70f8_b0e8a67c PS3, Line 40: #define HSPHY_MEM_VERIFIER_ERROR_STATUS (HSPHY_VERIFIER_BASE + 0x30) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/31555825_bc9934c2 PS3, Line 67: }__packed; space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/6166ea3f_70965024 PS3, Line 159: printk (BIOS_ERR, "Hash alg %d not supported, try SHA384\n", hash_alg); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/d3a56420_dd463d3f PS3, Line 186: i += sizeof (*push_model); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/4900a9a4_7dab8cdb PS3, Line 188: if ((push_model->address == 0) && (push_model->count == 0)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/1fcb18f9_77321a58 PS3, Line 194: i += sizeof (uint32_t); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/e5aa73cf_37a1e42a PS3, Line 275: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/3ce6bc5e_2c385d8a PS3, Line 312: hsphy_ver = REGBAR32(CPU_PID_PCIE_PHYx16_0, HSPHY_FW_VERSION);; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/d099ee3b_43e39bb6 PS3, Line 317: hsphy_ver = REGBAR32(CPU_PID_PCIE_PHYx16_1, HSPHY_FW_VERSION);; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150203): https://review.coreboot.org/c/coreboot/+/64074/comment/7a4d82d5_7ac16947 PS3, Line 344: } adding a line without newline at end of file