Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )
Change subject: mainboard/google/hatch: Add Palkia support
......................................................................
Patch Set 1:
(1 comment)
The error can be found in https://qa.coreboot.org/job/coreboot-gerrit/117388/testReport/junit/(root)/b...
SCONFIG mainboard/google/hatch/variants/baseboard/devicetree.cb
line 159: : syntax error
I'm not sure how reliable the line number is in an overridetree, but there's some syntax error _somewhere_.
Please merge this with its parent commit, so that we don't have a commit that adds inactive code to the tree. Otherwise we see errors here that are really the result of something in the other commit (like in this example).
https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG@7
PS1, Line 7: mainboard
mainboard is folder name under coreboot . […]
Originally, we spelled out paths in long form. For "mainboard" specifically, some contributors use the "mb" short hand. You _can_ use it, but you don't have to.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39096
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0
Gerrit-Change-Number: 39096
Gerrit-PatchSet: 1
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 24 Feb 2020 14:56:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment