Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46324 )
Change subject: soc/intel/broadwell: Revise SA lockdown sequence ......................................................................
Patch Set 4:
(1 comment)
This would be a lot easier to review if you wouldn't change semantics and introduce macros in the same patch. Macro names that I also can't review because I can't find them in docs (and the limited code in coreboot provides no hint if the names make sense).
https://review.coreboot.org/c/coreboot/+/46324/4/src/soc/intel/broadwell/fin... File src/soc/intel/broadwell/finalize.c:
https://review.coreboot.org/c/coreboot/+/46324/4/src/soc/intel/broadwell/fin... PS4, Line 36: REG_MMIO_OR32(MCH_BASE_ADDRESS + 0x7ffc, 1 << 0), Just kill it? ;)