[coreboot-gerrit] Change in ...coreboot[master]: sb/amd/agesa/hudson/Kconfig: Disable XHCI by default, enable only wit...

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30749 )

Change subject: sb/amd/agesa/hudson/Kconfig: Disable XHCI by default, enable only with firmware
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30749/1/src/southbridge/amd/agesa/hudson/Kco... 
File src/southbridge/amd/agesa/hudson/Kconfig:

https://review.coreboot.org/#/c/30749/1/src/southbridge/amd/agesa/hudson/Kco... 
PS1, Line 45: 	select HUDSON_XHCI_FWM
> Out of 4 there are 3 valid combinations of HUDSON_XHCI_ENABLE + HUDSON_XHCI_FWM : […]

Again, y + n may have unfortunate results, but is *not* invalid. Somebody could
still want to add the blob later to their `coreboot.rom` (and have coreboot
enable xHCI).

If you'd do what I suggested, you would have sane defaults, either n + n or
y + y, depending on USE_BLOBS. That's the best we can do, I guess.