Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Paul Menzel, Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )
Change subject: sc7280: Provide initial SoC support ......................................................................
Patch Set 42:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45205/comment/f8d0c83d_5fa791e6 PS15, Line 8:
Yes, please add the name and revision nevertheless, in case it gets public in the future, or interes […]
as per qcom policy, we are not permitted to share any document/ revision number externally. Internal SoC datasheets are accessible to customer through Qualcomm portal. we can’t share more to general public without involving PDM/Legal et al.
File Documentation/soc/qualcomm/sc7280/index.md:
https://review.coreboot.org/c/coreboot/+/45205/comment/7e56e08d_21c8f63a PS41, Line 18:
Please remove the blank lines at the end of the file.
Ack
File src/soc/qualcomm/sc7280/Kconfig:
https://review.coreboot.org/c/coreboot/+/45205/comment/0533bc19_688aacdf PS41, Line 1:
Please remove this blank line.
Done
File src/soc/qualcomm/sc7280/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45205/comment/48fa5873_3a4f818d PS41, Line 1:
Please remove the blank line.
Ack
https://review.coreboot.org/c/coreboot/+/45205/comment/44db7f92_1b1571c8 PS41, Line 1:
Please remove the blank line.
Done
File src/soc/qualcomm/sc7280/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/9c221311_c576e2bc PS41, Line 8: sc7280_mmu_init();
For the SC7180 this is done in decompressor.
Ack