Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34921 )
Change subject: arch/non-x86: Replace uses of __PRE_RAM__ ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34921/2/src/arch/riscv/include/arch... File src/arch/riscv/include/arch/memlayout.h:
https://review.coreboot.org/c/coreboot/+/34921/2/src/arch/riscv/include/arch... PS2, Line 23: #if !ENV_RAMSTAGE ENV_PRE_RAM would indeed be useful here.
https://review.coreboot.org/c/coreboot/+/34921/2/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-power8/uart.c:
https://review.coreboot.org/c/coreboot/+/34921/2/src/mainboard/emulation/qem... PS2, Line 44: #if ENV_RAMSTAGE follow-up wipes these out already
https://review.coreboot.org/c/coreboot/+/34921/2/src/soc/nvidia/tegra/dc.h File src/soc/nvidia/tegra/dc.h:
https://review.coreboot.org/c/coreboot/+/34921/2/src/soc/nvidia/tegra/dc.h@5... PS2, Line 518: #if ENV_RAMSTAGE should not be needed
https://review.coreboot.org/c/coreboot/+/34921/2/src/soc/samsung/exynos5420/... File src/soc/samsung/exynos5420/alternate_cbfs.c:
https://review.coreboot.org/c/coreboot/+/34921/2/src/soc/samsung/exynos5420/... PS2, Line 44: #if !ENV_RAMSTAGE ENV_PRE_RAM here too.