Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44699 )
Change subject: soc/mediatek/mt8192: Define DRAM registers and APIs
......................................................................
Patch Set 49:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44699/49/src/soc/mediatek/mt8192/in...
File src/soc/mediatek/mt8192/include/soc/dramc_pi_api.h:
https://review.coreboot.org/c/coreboot/+/44699/49/src/soc/mediatek/mt8192/in...
PS49, Line 271: flag
Please rename to "enable" to match the implementation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44699
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc64fb6c60d57184c4a2f9febe765b5cb69b39ae
Gerrit-Change-Number: 44699
Gerrit-PatchSet: 49
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 31 Dec 2020 03:41:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment