Attention is currently required from: Kyösti Mälkki. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58896 )
Change subject: ChromeOS: Add legacy mainboard_ec_running_ro() ......................................................................
Patch Set 7:
(1 comment)
File src/vendorcode/google/chromeos/gnvs.c:
https://review.coreboot.org/c/coreboot/+/58896/comment/2d01a2e3_0733445e PS7, Line 67: } Does anyone know what this is even good for? As far as I can tell this always gets overwritten by depthcharge (https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/refs/hea...) anyway. And it has to be, because on many boards the EC-RW jump only happens in depthcharge, so coreboot can't even know what the final EC state will be yet.
Can't we just get rid of this and related callbacks?