Attention is currently required from: jacz@semihalf.com, Jan Dabros, Duncan Laurie.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50910 )
Change subject: acpi/acpigen.h: Add more intuitive AML package closing functions
......................................................................
Patch Set 1:
(2 comments)
File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/50910/comment/f873385a_cce18a2d
PS1, Line 412: void acpigen_write_else(void);
It would require a lot of changes to be applied to existing code. […]
It would require some changes, and people would also need to get used to it. I'd like to know what others think about it. I don't really write acpigen myself.
https://review.coreboot.org/c/coreboot/+/50910/comment/3d807098_c9e1379c
PS1, Line 413: inline void acpigen_write_else_end(void)
For me it looks good. Like #endif in C preprocessor macros. […]
IMHO, yes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50910
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfdc3804cd93bde049cd11dec98758b3a639eafd
Gerrit-Change-Number: 50910
Gerrit-PatchSet: 1
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: jacz@semihalf.com
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Attention: Duncan Laurie
dlaurie@gmail.com
Gerrit-Comment-Date: Mon, 22 Feb 2021 10:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jacz@semihalf.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment