[coreboot-gerrit] Change in coreboot[master]: Moffet: Add two variants - arcada_cml & sarien_cml

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34887 )

Change subject: Moffet: Add two variants - arcada_cml & sarien_cml
......................................................................

Patch Set 5:

(3 comments)

Can any of the files just include the baseboard versions to cut down on the amount of duplicated code?

https://review.coreboot.org/c/coreboot/+/34887/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34887/5//COMMIT_MSG@7 
PS5, Line 7: Moffet:
What does "moffet" mean?  Should this be "mb/google/drallion: Add arcada_cml & sarien_cml variants"?

https://review.coreboot.org/c/coreboot/+/34887/5//COMMIT_MSG@9 
PS5, Line 9: EV
What is EV?

https://review.coreboot.org/c/coreboot/+/34887/5//COMMIT_MSG@11 
PS5, Line 11: EVT
Please, don't *EVER* mention the phase of a project.  This is confidential, along the lines of the OEM name, the name of the finished board, the OEM codename, the release date, etc.  Chrome Unboxed definitely reads the commit messages, so please don't leak any information you don't need to.  Please pass this along to everyone else as well.