Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine : Provide initial mainboard support ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45206/6/payloads/libpayload/configs... File payloads/libpayload/configs/config.herobrine:
https://review.coreboot.org/c/coreboot/+/45206/6/payloads/libpayload/configs... PS6, Line 5: CONFIG_LP_SC7280_SERIAL_CONSOLE=y Is the serial driver actually going to be different? I was hoping the QUPs stayed the same between the chips so you can just use the old driver here (and should probably give that a more generic name then).
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... PS6, Line 40: default 0xa Please don't define these before they're known. Just don't select the EC Kconfig for now.
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... PS6, Line 50: config GBB_HWID See the current Trogdor Kconfig, you don't need this option here anymore.
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... File src/mainboard/google/herobrine/board.h:
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... PS6, Line 21: #define GPIO_EN_PP3300_DX_EDP (CONFIG(TROGDOR_REV0) ? GPIO(106) : GPIO(30)) Please don't copy these GPIO tables, they'll be totally different for the new board.
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... File src/mainboard/google/herobrine/chromeos.c:
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... PS6, Line 9: #if 0 Just don't add any of this stuff if you don't have code for it yet.