Attention is currently required from: Hung-Te Lin, jason-ch chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74062 )
Change subject: soc/mediatek/mt8186: Reduce GPIO code size in bootblock
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74062/comment/e456548b_3f1ad998
PS3, Line 2: jason-ch chen
Is your name written jason-ch? You could also use a capital first letter.
https://review.coreboot.org/c/coreboot/+/74062/comment/47bd6f2e_f3cb2e12
PS3, Line 8:
Please describe the problem, and mention the sizes before and after.
https://review.coreboot.org/c/coreboot/+/74062/comment/1e141120_1cf70cfb
PS3, Line 13: jason-ch chen
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24775ba93cd74ae401747c2f5a26bbf1c8f6ac0a
Gerrit-Change-Number: 74062
Gerrit-PatchSet: 3
Gerrit-Owner: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 05:38:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment