Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47804 )
Change subject: soc/intel/elkhartlake: Fix EHL mainboard build fail errors ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47804/3/src/soc/intel/elkhartlake/i... File src/soc/intel/elkhartlake/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/47804/3/src/soc/intel/elkhartlake/i... PS3, Line 6: #include <soc/gpio_defs.h> : #include <intelblocks/gpio.h>
From the first look it seems like soc/gpio_defs. […]
Hi Werner, I was very happy when i moved #include <soc/gpio_defs.h> from here to intelblocks/gpio_defs.h and it worked. However, I got stumbled when I am porting this to all intel platforms, and it is not really possible or it required big changes for cannonlake as this is the code in cannonlake/incluse/soc/gpio.h: #if CONFIG(SOC_INTEL_CANNONLAKE_PCH_H) #include <soc/gpio_defs_cnp_h.h> #define CROS_GPIO_DEVICE_NAME "INT3450:00" #else #include <soc/gpio_defs.h> #define CROS_GPIO_DEVICE_NAME "INT34BB:00"
Do you have any better idea on how could we work this out?