Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37094 )
Change subject: Revert "3rdparts/fsp: Update fsp submodule"
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37094/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37094/2//COMMIT_MSG@11
PS2, Line 11: Reason for revert: Cannonlake FSP does not work anymore. FSP-M crashes/get stuck.
- It's a blob, what else should be done? […]
folks, could you re-try this part of the review and do it in a less adversarial way, please?
I think the request to figure out better what's going on is fine. Also, is there communication with Intel going on (e.g. on Github) to sort out what's going on there?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37094
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58ee2d7ee2c12558498f02219ee45d61d942077e
Gerrit-Change-Number: 37094
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 11 Dec 2019 19:02:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment