[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add STXS and CTXS method

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48943 )

Change subject: soc/amd/picasso: Add STXS and CTXS method
......................................................................

Patch Set 6: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/48943/6/src/soc/amd/common/acpi/gpi... 
File src/soc/amd/common/acpi/gpio_bank_lib.asl:

https://review.coreboot.org/c/coreboot/+/48943/6/src/soc/amd/common/acpi/gpi... 
PS6, Line 5: #define GPIO_OUTPUT_SHIFT	22
           : #define GPIO_OUTPUT_VALUE	(1 << GPIO_OUTPUT_SHIFT)
> Too many type conflict when I include that file...

Aah. I think what we need is basically reorganizing gpio_banks.h so that the #defines are at the top and rest of the structure and function declarations at bottom guarded by #ifndef __ACPI__.

Anyways, we can go ahead with this, but we should really get rid of the duplicate definitions.