Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35304 )
Change subject: mb/google/drallion: Update memory map
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35304/3/src/mainboard/google/dralli...
File src/mainboard/google/drallion/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/35304/3/src/mainboard/google/dralli...
PS3, Line 36: 0x17c8000
Does this fall on a boundary that is supported by the SPI flash to enable write protect?
I use dump_fmap to check the WP_RO range, it shows start 0x01c00000 - end 0x02000000 that is same as before this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5be2580d280569421d0870a06f9b93124b564b6f
Gerrit-Change-Number: 35304
Gerrit-PatchSet: 3
Gerrit-Owner: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 11 Sep 2019 03:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment