Edward Hill has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function
......................................................................
Patch Set 8: Code-Review+2
I think this is ok to unblock treeya, but I agree with Furquan that it would be good to have a common sku_id() implementation, and refactor somehow to avoid having both "__weak uint32_t sku_id()" and "uint8_t __weak variant_board_sku()".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I631f62021e8104a69a43667a811c9c23e3105596
Gerrit-Change-Number: 35214
Gerrit-PatchSet: 8
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Edward Hill
ecgh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Magf -
magf@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Sep 2019 16:33:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment