[coreboot-gerrit] Change in coreboot[master]: cpu/intel/model_206ax: Use static.c exposed lapic 0

[Arthur Heymans (Code Review)]

Attention is currently required from: Arthur Heymans, Patrick Rudolph.
Hello Arthur Heymans,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/59316

to review the following change.

Change subject: cpu/intel/model_206ax: Use static.c exposed lapic 0
......................................................................

cpu/intel/model_206ax: Use static.c exposed lapic 0

Change-Id: Id3b1c4ca027e2905535e137691c3e3e60417dbf3
Signed-off-by: Arthur Heymans 
---
M src/cpu/intel/model_206ax/acpi.c
M src/cpu/intel/model_206ax/chip.h
M src/cpu/intel/model_206ax/model_206ax_init.c
3 files changed, 2 insertions(+), 21 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/59316/1

diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c
index f1d03c8..2281229 100644
--- a/src/cpu/intel/model_206ax/acpi.c
+++ b/src/cpu/intel/model_206ax/acpi.c
@@ -97,16 +97,7 @@

static void generate_C_state_entries(void)
 {
-	struct device *lapic;
-	struct cpu_intel_model_206ax_config *conf = NULL;
-
-	/* Find the SpeedStep CPU in the device tree using magic APIC ID */
-	lapic = dev_find_lapic(SPEEDSTEP_APIC_MAGIC);
-	if (!lapic)
-		return;
-	conf = lapic->chip_info;
-	if (!conf)
-		return;
+	struct cpu_intel_model_206ax_config *conf = config_of(config_of_lapic());

const int acpi_cstates[3] = { conf->acpi_c1, conf->acpi_c2, conf->acpi_c3 };

diff --git a/src/cpu/intel/model_206ax/chip.h b/src/cpu/intel/model_206ax/chip.h
index 4fff04a..1120823 100644
--- a/src/cpu/intel/model_206ax/chip.h
+++ b/src/cpu/intel/model_206ax/chip.h
@@ -1,8 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-/* Magic value used to locate this chip in the device tree */
-#define SPEEDSTEP_APIC_MAGIC 0xACAC
-
 struct cpu_intel_model_206ax_config {
    int acpi_c1;		/* ACPI C1 */
    int acpi_c2;		/* ACPI C2 */
diff --git a/src/cpu/intel/model_206ax/model_206ax_init.c b/src/cpu/intel/model_206ax/model_206ax_init.c
index 9de6b38..9602980 100644
--- a/src/cpu/intel/model_206ax/model_206ax_init.c
+++ b/src/cpu/intel/model_206ax/model_206ax_init.c
@@ -216,16 +216,9 @@

static void configure_thermal_target(void)
 {
-	struct cpu_intel_model_206ax_config *conf;
-	struct device *lapic;
+	struct cpu_intel_model_206ax_config *conf = config_of(config_of_lapic());
    msr_t msr;

-	/* Find pointer to CPU configuration */
-	lapic = dev_find_lapic(SPEEDSTEP_APIC_MAGIC);
-	if (!lapic || !lapic->chip_info)
-		return;
-	conf = lapic->chip_info;
-
    /* Set TCC activation offset if supported */
    msr = rdmsr(MSR_PLATFORM_INFO);
    if ((msr.lo & (1 << 30)) && conf->tcc_offset) {