Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84414?usp=email )
(
5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google: Correct number of jacks in hda_verb.c ......................................................................
mb/google: Correct number of jacks in hda_verb.c
This corrects the mismatch found in the verb tables of Monroe Chromebase and Link Chromebook.
The verb data was not aligned to a multiple of 4, therefore an entry was repeated as padding.
This was found due to the `_Static_assert()` from CB:84360 failing.
TEST=Tested on LINK under Linux and Win11, audio working properly under both.
Change-Id: Id377281af310642a6ba77e5a0002ca1dfca38827 Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84414 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/link/hda_verb.c 2 files changed, 5 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c index 064bebf..3b529e2 100644 --- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c +++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c @@ -6,7 +6,7 @@ /* coreboot specific header */ 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x00000010, // Number of jacks (NID entries)
0x0017ff00, // Function Reset 0x0017ff00, // Double Function Reset diff --git a/src/mainboard/google/link/hda_verb.c b/src/mainboard/google/link/hda_verb.c index 9381b57..d3309cd 100644 --- a/src/mainboard/google/link/hda_verb.c +++ b/src/mainboard/google/link/hda_verb.c @@ -6,7 +6,7 @@ /* coreboot specific header */ 0x11020011, // Codec Vendor / Device ID: Creative CA0132 0x10280550, // Subsystem ID - 0x00000014, // Number of jacks + Number of Malcolm setup blocks. + 0x00000015, // Number of jacks + Number of Malcolm setup blocks.
/* Malcolm Setup */
@@ -62,6 +62,9 @@
/* Enable and set EAPD pin for headphone jack */ AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), + AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), /* Padding */ + AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), /* Padding */ + AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), /* Padding */
/* Pin Widget Verb Table */