William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41797 )
Change subject: mb/google/volteer: move volteer-specific GPIOs to variant gpio.c ......................................................................
Patch Set 7:
(4 comments)
Nick, would you please help to correct same malefor settings during your CL?
https://review.coreboot.org/c/coreboot/+/41797/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/41797/7/src/mainboard/google/voltee... PS7, Line 114: /* E10 : SPI1_CS# ==> USB_C0_AUXP_DC */ : PAD_CFG_GPO(GPP_E10, 0, DEEP), This pin should removed since MB side need AUX function which should keep same as baseboard settings.
https://review.coreboot.org/c/coreboot/+/41797/7/src/mainboard/google/voltee... PS7, Line 120: /* E13 : SPI1_MOSI_IO0 ==> USB_C0_AUXN_DC */ : PAD_CFG_GPO(GPP_E13, 0, DEEP), This pin should removed since MB side need AUX function which should keep same as baseboard settings.
https://review.coreboot.org/c/coreboot/+/41797/7/src/mainboard/google/voltee... PS7, Line 150: /* H20 : IMGCLKOUT1 ==> EN_MIPI_RCAM_PWR */ : PAD_CFG_GPO(GPP_H20, 1, PLTRST), malefor doesn't use MIPI camera, so this pin should same as baseboard with NC settings.
https://review.coreboot.org/c/coreboot/+/41797/7/src/mainboard/google/voltee... PS7, Line 222: /* F11 : THC1_SPI2_CLK ==> EN_PP3300_WWAN */ : PAD_CFG_GPO(GPP_F11, 1, DEEP), : : /* F12 : GSXDOUT ==> WWAN_RST_ODL : To meet timing constrains - drive reset low. : Deasserted in ramstage. */ : PAD_CFG_GPO(GPP_F12, 0, DEEP), malefor doesn't need these WWAN related GPIO settings, should keep NC.