Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
Patch Set 1:
I don't recall any objections at the time 😊
Well, not everything can be catched always ;) There's always room to improve, so why not start now? :-)
personally, I find it much more clear when board specific options are selected in `Kconfig.name`. If these were two variants derived from two different baseboards, then I'd agree it would make more sense to declare those in Kconfig and have the boards select those. But for a small number of board-specific selects? Not so much.
I'm aware I could just guard the SoC selection in Kconfig by board, but IMO that gets ugly when you have `select SOC_XXX if BOARD_X || BOARD_Y || BOARD_Z` and then the same for the other SoC