Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33429 )
Change subject: {mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33429/2/src/mainboard/amd/serengeti_cheetah_...
File src/mainboard/amd/serengeti_cheetah_fam10/fadt.c:
https://review.coreboot.org/#/c/33429/2/src/mainboard/amd/serengeti_cheetah_...
PS2, Line 38:
What would 'typeof header' say?
Or does this 'header->length' refer to the whole table's length?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33429
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I671daab8a654b690cec4c872e800b196f7975b9d
Gerrit-Change-Number: 33429
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 13 Jun 2019 12:28:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment