Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30466 )
Change subject: soc/sifive/fu540: add code to initialize flash ......................................................................
Patch Set 13: Code-Review+1
(3 comments)
Thanks! Do you need to call flash_init in both romstage and bootblock? And could you also mention in the commit message how you tested it. E.g. TEST=Loaded a 20MB image on HiFive unleashed
https://review.coreboot.org/#/c/30466/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30466/6//COMMIT_MSG@10 PS6, Line 10: available. I fixed it to use all 32MB.
Done
Done
https://review.coreboot.org/#/c/30466/6/src/mainboard/sifive/hifive-unleashe... File src/mainboard/sifive/hifive-unleashed/flash.c:
https://review.coreboot.org/#/c/30466/6/src/mainboard/sifive/hifive-unleashe... PS6, Line 30: .command_code = 0x6c
Done
Done
https://review.coreboot.org/#/c/30466/6/src/mainboard/sifive/hifive-unleashe... PS6, Line 40: 0x66,
Done
Done