Do you need to call flash_init in both romstage and bootblock?
And could you also mention in the commit message how you tested it. E.g.
TEST=Loaded a 20MB image on HiFive unleashed

Patch set 13:Code-Review +1

View Change


To view, visit change 30466. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cd803369da5526eff90400c15b91bbf6b477c69
Gerrit-Change-Number: 30466
Gerrit-PatchSet: 13
Gerrit-Owner: Xiang Wang <>
Gerrit-Reviewer: Jonathan Neuschäfer <>
Gerrit-Reviewer: Martin Roth <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Philipp Hug <>
Gerrit-Reviewer: Shawn C <>
Gerrit-Reviewer: Xiang Wang <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-Reviewer: ron minnich <>
Gerrit-Comment-Date: Sat, 26 Jan 2019 08:46:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Xiang Wang <>
Comment-In-Reply-To: Philipp Hug <>
Gerrit-MessageType: comment