Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32438 )
Change subject: mb/google/sarein: Disable touch by strap pin GPP_B4
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/32438/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32438/4//COMMIT_MSG@9
PS4, Line 9: We want to disable touch for none touch sku. We can use
: strap pin GPP_B4 to identify it is connected with touch
: or not.
Please add a blank line below (between paragraphs).
https://review.coreboot.org/#/c/32438/4//COMMIT_MSG@12
PS4, Line 12: If GPP_B4 is low level that means touch sku.
: If GPP_B4 is high level that means none-touch sku.
Please format that as a list.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32438
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6681262c25e4b01e061a8520e38905d40345509
Gerrit-Change-Number: 32438
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 24 Apr 2019 11:53:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment