build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43804 )
Change subject: soc/amd/acpi: Move ACPI IVRS generation to coreboot ......................................................................
Patch Set 22:
(9 comments)
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... File src/soc/amd/picasso/agesa_acpi.c:
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... PS22, Line 403: ivrs->ivhd.flags |= ((mmio_x30_value & MMIO_EXT_FEATURE_PPR_SUP) ? IVHD_FLAG_PPE_SUP : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... PS22, Line 404: ivrs->ivhd.flags |= ((mmio_x30_value & MMIO_EXT_FEATURE_PRE_F_SUP) ? IVHD_FLAG_PREF_SUP : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... PS22, Line 405: ivrs->ivhd.flags |= ((mmio_x18_value & MMIO_CTRL_COHERENT) ? IVHD_FLAG_COHERENT : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... PS22, Line 406: ivrs->ivhd.flags |= ((cap_offset_0 & CAP_OFFSET_0_IOTLB_SP) ? IVHD_FLAG_IOTLB_SUP : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... PS22, Line 408: ivrs->ivhd.flags |= ((mmio_x18_value & MMIO_CTRL_RES_PASS_PW) ? IVHD_FLAG_RES_PASS_PW : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... PS22, Line 409: ivrs->ivhd.flags |= ((mmio_x18_value & MMIO_CTRL_PASS_PW) ? IVHD_FLAG_PASS_PW : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... PS22, Line 410: ivrs->ivhd.flags |= ((mmio_x18_value & MMIO_CTRL_HT_TUN_EN) ? IVHD_FLAG_HT_TUN_EN : 0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... PS22, Line 436: ivrs->ivhd.iommu_feature_info |= (mmio_x30_value & MMIO_EXT_FEATURE_PAS_MAX_MASK) line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/22/src/soc/amd/picasso/agesa_... PS22, Line 444: ivrs->ivhd.iommu_feature_info |= (mmio_x30_value & MMIO_EXT_FEATURE_GLX_SUP_MASK) line over 96 characters