Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87082?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/starlabs/starbook/adl_n: Remove comments for GPIOs that aren't connected ......................................................................
mb/starlabs/starbook/adl_n: Remove comments for GPIOs that aren't connected
This is a non-functional change; it just makes it easier to read.
Change-Id: Ib3f87c6e3e83d57c4e6969c3aac7cae02d750a5c Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/87082 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 0 insertions(+), 149 deletions(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 19b3cc8..43f2213 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -99,312 +99,163 @@ PAD_NC(GPD10, NONE), PAD_NC(GPD11, NONE),
- /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), - /* A6: Not Connected */ PAD_NC(GPP_A6, NONE), - /* A7: Embedded Controller SCI */ PAD_NC(GPP_A7, NONE), - /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), - /* A12: Not Connected */ PAD_NC(GPP_A12, NONE), - /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), - /* A15: Test Point 52 */ PAD_NC(GPP_A15, NONE), - /* A16: USB OverCurrent 3 */ PAD_NC(GPP_A16, NONE), - /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A20: Test Point 44 */ PAD_NC(GPP_A20, NONE), - /* A21: Fingerprint Reader Interrupt */ PAD_NC(GPP_A21, NONE), - /* A22: Fingerprint Reader Reset */ PAD_NC(GPP_A22, NONE), - /* A23: Not Connected */ PAD_NC(GPP_A23, NONE),
- - /* B3: Not Connected */ PAD_NC(GPP_B3, NONE), - /* B4: Not Connected */ PAD_NC(GPP_B4, NONE), - /* B5: I2C 2 SDA Touch Panel SDA */ PAD_NC(GPP_B5, NONE), - /* B6: I2C 2 SCL Touch Panel Clock */ PAD_NC(GPP_B6, NONE), - /* B9: Not Connected */ PAD_NC(GPP_B9, NONE), - /* B10: Not Connected */ PAD_NC(GPP_B10, NONE), - /* B11: Not Connected */ PAD_NC(GPP_B11, NONE), - /* B12: PM SLP S0 */ PAD_NC(GPP_B12, NONE), - /* B15: Not Connected */ PAD_NC(GPP_B15, NONE), - /* B16: Not Connected */ PAD_NC(GPP_B16, NONE), - /* B17: Not Connected */ PAD_NC(GPP_B17, NONE), - /* B19: Not Connected */ PAD_NC(GPP_B19, NONE), - /* B20: Not Connected */ PAD_NC(GPP_B20, NONE), - /* B21: Not Connected */ PAD_NC(GPP_B21, NONE), - /* B22: Not Connected */ PAD_NC(GPP_B22, NONE), - /* B23: Not used MiPi Camera */ PAD_NC(GPP_B23, NONE), - /* B24: Not Connected */ PAD_NC(GPP_B24, NONE), - /* B25: Not Connected */ PAD_NC(GPP_B25, NONE),
- /* C3: SML 0 Clock */ PAD_NC(GPP_C3, NONE), - /* C4: SML 0 Data */ PAD_NC(GPP_C4, NONE), - /* C6: SML 1 Clock */ PAD_NC(GPP_C6, NONE), - /* C7: SML 1 Data */ PAD_NC(GPP_C7, NONE), - /* C8: Not Connected */ PAD_NC(GPP_C8, NONE), - /* C9: Not Connected */ PAD_NC(GPP_C9, NONE), - /* C10: Not Connected */ PAD_NC(GPP_C10, NONE), - /* C11: Not Connected */ PAD_NC(GPP_C11, NONE), - /* C12: Not Connected */ PAD_NC(GPP_C12, NONE), - /* C13: Not Connected */ PAD_NC(GPP_C13, NONE), - /* C14: Not Connected */ PAD_NC(GPP_C14, NONE), - /* C15: Not Connected */ PAD_NC(GPP_C15, NONE), - /* C16: Not Connected */ PAD_NC(GPP_C16, NONE), - /* C17: Not Connected */ PAD_NC(GPP_C17, NONE), - /* C18: Not Connected */ PAD_NC(GPP_C18, NONE), - /* C19: Not Connected */ PAD_NC(GPP_C19, NONE), - /* C20: Not Connected */ PAD_NC(GPP_C20, NONE), - /* C21: Not Connected */ PAD_NC(GPP_C21, NONE), - /* C22: Not Connected */ PAD_NC(GPP_C22, NONE), - /* C23: Not Connected */ PAD_NC(GPP_C23, NONE),
- /* D0: Not used Audio ID 0 */ PAD_NC(GPP_D0, NONE), - /* D1: Not used Audio ID 1 */ PAD_NC(GPP_D1, NONE), - /* D2: Not used Audio ID 2 */ PAD_NC(GPP_D2, NONE), - /* D3: Not Connected */ PAD_NC(GPP_D3, NONE), - /* D4: Not Connected */ PAD_NC(GPP_D4, NONE), - /* D7: Clock Request 2 */ PAD_NC(GPP_D7, NONE), - /* D8: Clock Request 3 */ PAD_NC(GPP_D8, NONE), - /* D9: GSPI 2 FPS */ PAD_NC(GPP_D9, NONE), - /* D10: GSPI 2 Clock */ PAD_NC(GPP_D10, NONE), - /* D11: GSPI 2 MISO FPS */ PAD_NC(GPP_D11, NONE), - /* D13: Wireless LAN Wake */ PAD_NC(GPP_D13, NONE), - /* D14: CPU M.2 SSD Power Enable */ PAD_NC(GPP_D14, NONE), - /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), - /* D17: Not used Fingerprint ID */ PAD_NC(GPP_D17, NONE), - /* D18: Not Connected */ PAD_NC(GPP_D18, NONE), - /* D19: Test Point 21 */ PAD_NC(GPP_D19, NONE),
- /* E0: SATA x PCIe */ PAD_NC(GPP_E0, NONE), - /* E1: Not used Accelerometer Interrupt */ PAD_NC(GPP_E1, NONE), - /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), - /* E4: Test Point 14 */ PAD_NC(GPP_E4, NONE), - /* E5: Not Connected */ PAD_NC(GPP_E5, NONE), - /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E9: USB OverCurrent 0 */ PAD_NC(GPP_E9, NONE), - /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), - /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E15: Not Connected */ PAD_NC(GPP_E15, NONE), - /* E16: Not Connected */ PAD_NC(GPP_E16, NONE), - /* E17: Not Connected */ PAD_NC(GPP_E17, NONE), - /* E18: Not Connected */ PAD_NC(GPP_E18, NONE), - /* E20: Not Connected */ PAD_NC(GPP_E20, NONE), - /* E22: Not Connected */ PAD_NC(GPP_E22, NONE), - /* E23: Not Connected */ PAD_NC(GPP_E23, NONE),
- /* F0: CNV BRI Data */ PAD_NC(GPP_F0, NONE), - /* F1: CNV BRI Response */ PAD_NC(GPP_F1, NONE), - /* F3: CNV RGI Response */ PAD_NC(GPP_F3, NONE), - /* F4: CNV RF Reset */ PAD_NC(GPP_F4, NONE), - /* F5: Not used MODEM_CLKREQ */ PAD_NC(GPP_F5, NONE), - /* F6: CNV PA Blanking */ PAD_NC(GPP_F6, NONE), - /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), - /* F9: */ PAD_NC(GPP_F9, NONE), - /* F10: Not Connected */ PAD_NC(GPP_F10, NONE), - /* F11: TPM ID */ PAD_NC(GPP_F11, NONE), - /* F12: Not Connected */ PAD_NC(GPP_F12, NONE), - /* F13: Not Connected */ PAD_NC(GPP_F13, NONE), - /* F14: Not Connected */ PAD_NC(GPP_F14, NONE), - /* F15: Not used */ PAD_NC(GPP_F15, NONE), - /* F16: Not Connected */ PAD_NC(GPP_F16, NONE), - /* F17: Not used */ PAD_NC(GPP_F17, NONE), - /* F18: Not used */ PAD_NC(GPP_F18, NONE), - /* F19: Not Connected */ PAD_NC(GPP_F19, NONE), - /* F20: Not Connected */ PAD_NC(GPP_F20, NONE), - /* F21: Not Connected */ PAD_NC(GPP_F21, NONE), - /* F22: Not Connected */ PAD_NC(GPP_F22, NONE), - /* F23: Not Connected */ PAD_NC(GPP_F23, NONE),
- /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), - /* H4: I2C 0 SDA Touchpad */ PAD_NC(GPP_H4, NONE), - /* H5: I2C 0 SCL Touchpad */ PAD_NC(GPP_H5, NONE), - /* H6: Not Connected */ PAD_NC(GPP_H6, NONE), - /* H7: Not Connected */ PAD_NC(GPP_H7, NONE), - /* H8: I2C 4 SDA GSensor */ PAD_NC(GPP_H8, NONE), - /* H9: I2C 4 SDL GSensor */ PAD_NC(GPP_H9, NONE), - /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), - /* H13: PCH M.2 SSD Device Sleep */ PAD_NC(GPP_H13, NONE), - /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H19: Clock Request 4 CPU M.2 SSD */ PAD_NC(GPP_H19, NONE), - /* H20: Not Connected */ PAD_NC(GPP_H20, NONE), - /* H21: Not Connected */ PAD_NC(GPP_H21, NONE), - /* H22: Not Connected */ PAD_NC(GPP_H22, NONE), - /* H23: Clock Request 5 */ PAD_NC(GPP_H23, NONE),
- /* S0: Not Connected */ PAD_NC(GPP_S0, NONE), - /* S1: Not Connected */ PAD_NC(GPP_S1, NONE), - /* S2: DMIC Clock */ PAD_NC(GPP_S2, NONE), - /* S3: DMIC Data */ PAD_NC(GPP_S3, NONE), - /* S4: Not Connected */ PAD_NC(GPP_S4, NONE), - /* S5: Not Connected */ PAD_NC(GPP_S5, NONE), - /* S6: Not Connected */ PAD_NC(GPP_S6, NONE), - /* S7: Not Connected */ PAD_NC(GPP_S7, NONE),
- /* T0: Not Connected */ PAD_NC(GPP_T0, NONE), - /* T1: Not Connected */ PAD_NC(GPP_T1, NONE), - /* T2: Not Connected */ PAD_NC(GPP_T2, NONE), - /* T3: Not Connected */ PAD_NC(GPP_T3, NONE), - /* T4: Not Connected */ PAD_NC(GPP_T4, NONE), - /* T5: Not Connected */ PAD_NC(GPP_T5, NONE), - /* T6: Not Connected */ PAD_NC(GPP_T6, NONE), - /* T7: Not Connected */ PAD_NC(GPP_T7, NONE), - /* T8: Not Connected */ PAD_NC(GPP_T8, NONE), - /* T9: Not Connected */ PAD_NC(GPP_T9, NONE), - /* T10: Not Connected */ PAD_NC(GPP_T10, NONE), - /* T11: Not Connected */ PAD_NC(GPP_T11, NONE), - /* T12: Not Connected */ PAD_NC(GPP_T12, NONE), - /* T13: Not Connected */ PAD_NC(GPP_T13, NONE), - /* T14: Not Connected */ PAD_NC(GPP_T14, NONE), - /* T15: Not Connected */ PAD_NC(GPP_T15, NONE),
PAD_NC(GPP_R5, NONE), - /* R6: Not Connected */ PAD_NC(GPP_R6, NONE), - /* R7: Not Connected */ PAD_NC(GPP_R7, NONE), };