Martin Roth has posted comments on this change. ( https://review.coreboot.org/29009 )
Change subject: amd/stoneyridge: Convert hex definitions to lower case ......................................................................
Patch Set 1:
(2 comments)
A couple of comments unrelated to this change.
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbde... File src/soc/amd/stoneyridge/enable_usbdebug.c:
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbde... PS1, Line 32: return PCI_DEV(0, 0x16, 0); : else if (hcd_idx == 2) : return PCI_DEV(0, 0x13, 0); I don't think these two exist on stoney.
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbde... PS1, Line 36: PCI_DEV(0, 0x12, 0) SOC_EHCI1_DEV