Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: lib/spd: respect spd memory part name override if present ......................................................................
Patch Set 36:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45459/36/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/36/src/lib/spd_bin.c@10 PS36, Line 10: struct ugh, i see const is propagating... could you fix this API so we don't need the awkward cast on 17?
https://review.coreboot.org/c/coreboot/+/45459/36/src/lib/spd_bin.c@193 PS36, Line 193: (const uint8_t *) isn't spd already of this type?
https://review.coreboot.org/c/coreboot/+/45459/36/src/soc/intel/cannonlake/c... File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/c/coreboot/+/45459/36/src/soc/intel/cannonlake/c... PS36, Line 83: spd_data_ptr rdev_mmap_full returns a void * so i think you can eliminate eliminate the (const uint8_t *) cast by making this a void *.