Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37400 )
Change subject: sb/amd/{agesa,pi}: use ACPIMMIO common block wherever possible ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37400/2/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/early_setup.c:
https://review.coreboot.org/c/coreboot/+/37400/2/src/southbridge/amd/agesa/h... PS2, Line 87: int s3_save_nvram_early(u32 dword, int size, int nvram_pos)
Separate commit, remove as unused and prototypes in hudson.h too. […]
Done
https://review.coreboot.org/c/coreboot/+/37400/2/src/southbridge/amd/agesa/h... PS2, Line 101: int s3_load_nvram_early(int size, u32 *old_dword, int nvram_pos)
as above
Done
https://review.coreboot.org/c/coreboot/+/37400/2/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/early_setup.c:
https://review.coreboot.org/c/coreboot/+/37400/2/src/southbridge/amd/pi/huds... PS2, Line 229: int s3_save_nvram_early(u32 dword, int size, int nvram_pos)
remove
Done
https://review.coreboot.org/c/coreboot/+/37400/2/src/southbridge/amd/pi/huds... PS2, Line 242: int s3_load_nvram_early(int size, u32 *old_dword, int nvram_pos)
remove
Done