23 May
2019
23 May
'19
2:40 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23135 )
Change subject: superio: Add ASpeed AST2400 ......................................................................
Patch Set 29:
(2 comments)
https://review.coreboot.org/#/c/23135/29/src/superio/aspeed/ast2400/ast2400.... File src/superio/aspeed/ast2400/ast2400.h:
https://review.coreboot.org/#/c/23135/29/src/superio/aspeed/ast2400/ast2400.... PS29, Line 21: #include <arch/io.h> all includes are unused
https://review.coreboot.org/#/c/23135/29/src/superio/aspeed/ast2400/ast2400.... PS29, Line 36: void pnp_enter_ext_func_mode(pnp_devfn_t dev); all function prototypes are unused and can be removed
--
To view, visit https://review.coreboot.org/c/coreboot/+/23135
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58fce31f0a2483e61e9d31f38ab5a059b8cf4f83
Gerrit-Change-Number: 23135
Gerrit-PatchSet: 29
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Thu, 23 May 2019 12:40:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment