[coreboot-gerrit] Change in coreboot[master]: libpayload: Add uart/serial driver support for trogdor

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35960 )

Change subject: libpayload: Add uart/serial driver support for trogdor
......................................................................

Patch Set 35:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35960/35/payloads/libpayload/driver... 
File payloads/libpayload/drivers/serial/qcom_qupv3_serial.c:

https://review.coreboot.org/c/coreboot/+/35960/35/payloads/libpayload/driver... 
PS35, Line 314: 	if (data == 0xa)
> This is a newline... […]

Ack

https://review.coreboot.org/c/coreboot/+/35960/35/payloads/libpayload/driver... 
PS35, Line 316: 	uart_qupv3_tx_byte(data);
> That is not what this does, there's no 'else' up there. […]

Ack