Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29371 )
Change subject: drivers/intel/fsp1_1/raminit.c: Make check FSP HOBs independent of CONFIG_DISPLAY_HOBS ......................................................................
Patch Set 3:
(3 comments)
Please clean up and separate HOB checking and HOB displaying. You have also enabled prints that are a part of displaying the hobs after removing the macro.
https://review.coreboot.org/#/c/29371/3/src/drivers/intel/fsp1_1/raminit.c File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/#/c/29371/3/src/drivers/intel/fsp1_1/raminit.c@2... PS3, Line 209: printk(BIOS_DEBUG, These prints could be moved to the print_hob_type_structure function possibly? It is kind of displaying the HOB information.
https://review.coreboot.org/#/c/29371/3/src/drivers/intel/fsp1_1/raminit.c@2... PS3, Line 224: printk(BIOS_DEBUG, Let's print only an error message in case of missing HOB. The debug print should be in print_hob_type_structure function then.
https://review.coreboot.org/#/c/29371/3/src/drivers/intel/fsp1_1/raminit.c@2... PS3, Line 229: printk(BIOS_DEBUG, These prints should be moved too. The check for missing HOB is done earlier.