Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37842 )
Change subject: southbridge: Add missing include <device/pci_def.h> ......................................................................
Patch Set 1: -Code-Review
(2 comments)
Well on second look, lots of PCI_COMMAND uses there. But for now, let's not add pci_def.h for PCI_SLOT() or PCI_DEVFN().
https://review.coreboot.org/c/coreboot/+/37842/1/src/southbridge/intel/commo... File src/southbridge/intel/common/rcba_pirq.c:
https://review.coreboot.org/c/coreboot/+/37842/1/src/southbridge/intel/commo... PS1, Line 18: #include <device/pci_def.h> don't add
https://review.coreboot.org/c/coreboot/+/37842/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801dx/i82801dx.c:
https://review.coreboot.org/c/coreboot/+/37842/1/src/southbridge/intel/i8280... PS1, Line 19: #include <device/pci_def.h> don't add