HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31049 )
Change subject: src: Don't use a #defines like Kconfig symbols
......................................................................
Patch Set 2:
Did you test with `make BUILD_TIMELESS=1`, that nothing changed?
No I didn't
Test with BUILD_TIMELESS=1 done on :
(MS-9652) gives me the same md5sum before and after: c607b365c169b93a1e5602dbdef8e35c build/coreboot.rom
(Stumpy)gives me also the same md5sum: f3f2cabdb704dad98bc644b3d3aceec5 build/coreboot.rom
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31049
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia31aed366bf768ab167ed5f8595bee8234aac46b
Gerrit-Change-Number: 31049
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 24 Jan 2019 08:09:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment