Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35531 )
Change subject: Makefile: Create the build directory before bootblock.bin
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35531/3/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35531/3/Makefile.inc@507
PS3, Line 507: build-dirs $(objcbfs) $(objgenerated):
Why didn't you just add 'build-dirs' as a dependency to the bootblock.bin target? […]
I mean, that's how make is supposed to work? If it didn't before then maybe there was/is another hidden error somewhere, but then we should find and fix that rather than doing some weird other solution that looks wrong and where nobody can explain why it works better than the obvious solution.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35531
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4cd4fe8ac82bd1e9ce114dbd53763538d125af3
Gerrit-Change-Number: 35531
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 04:21:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment