Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39362 )
Change subject: sc7180: Adjust memory allocations per upstream comments ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39362/3/src/soc/qualcomm/sc7180/inc... File src/soc/qualcomm/sc7180/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/39362/3/src/soc/qualcomm/sc7180/inc... PS3, Line 65: 0x300000 Saurabh said that we don't need the TZ_STAT region for coreboot builds, so can we reduce this to 2MB now? (Also would be more readable to write this as 2M and dram_aop as 256K.)
Can move BL31 down to 0x80B00000 then to avoid leaving a hole.
https://review.coreboot.org/c/coreboot/+/39362/3/src/soc/qualcomm/sc7180/inc... PS3, Line 66: 2M Comments on the bug said 1MB, any reason why it needs to be 2 now? (Remember we can always update this if it grows later, there's no need to leave room for expansion here.